So this one already has a metamodule supported release… @danngreen let me know how ideally to best merge my changes in, there are a few new sapphire modules that I ported over that aren’t in the currently available version.
7 Likes
Best thing to do here would be to make a Pull Request for the metamodule branch on the 4ms fork of Sapphire:
But, in conversation with Don Cross (creator of Sapphire), there were some modules we felt should be omitted. It was a while ago and I can’t remember which ones. I need to re-read our correspondence to refresh my memory, but the VCV Rack forum is down at the moment…
Anyways, in general for situations like this where you’re making changes to an existing MM plugin, my preferred way is for you to make your own fork of the repo and then make a PR from your fork, to 4ms repo.
I just pushed some changes I had made to my fork of Sapphire, which was just putting the MM cmake and support files into a metamodule/ directory inside the repo (so there’s no wrapper repo needed). So you would need to merge your changes from your metamodule-sapphire repo with the 4ms Sapphire fork (metamodule branch), into your Sapphire repo. Then make the PR from your Sapphire fork to the 4ms Sapphire fork (again, use the metamodule branch, not main)
Thanks! Optimizing nucleus for MetaModule · Issue #131 · cosinekitty/sapphire · GitHub - just for recordkeeping, I believe they are okay with this