Please note: I spoke with Nick of Infrasonic Audio, he is okay with the port but I’d like to make clear that any issues with this port should be directed to me - please do not bother him with requests about this. Per his request, I have also renamed it to Phase Oscillator where possible (I can’t everywhere, because then the VCV version doesn’t map over to the MM), and removed his logo and module title.
*minor note: The PM knob on the top right has a dual function usually accessible via the options menu. I might move this out into a separate knob - but you might see some weirdness sometimes where you can assign two knobs to the top right one - this is normal and is how the VCV rack version works.
@danngreen Is there a way to rename the MM version while retaining VCV → MM compatibility? I’d like to name this something different completely per Nick’s request, but changing the name breaks the VCV Rack to MM compatibility.
Oh right, there’s no way yet to rename a module itself. I do it with the CloneInstruments but I didn’t extend that to the plugin SDK.
You can use the name field in the MetaModuleIncludedModules list. That will at least change how its displayed on the website.
Probably what I’ll do is have it use this field for displaying on the module list, too. It shouldn’t be hard to implement, so if you want to go ahead and change the name in the plugin-mm.json, then I can use this plugin to make sure its working.
Yeah, the slug is the only guaranteed unique identifier. So the hub stores the brand slugs and the module slugs in the patch yaml file. Then when you load a plugin it registers the module slugs under the brand slug. The module slugs are defined in the createModel(“slug”) call. The brand slug is extracted from the plugin.json.
When you load a patch file it looks up the slugs from the yaml file in the module registry to figure out which module to load.
The Internal PM Level knob is displayed behind the Ratio knob, so it appears that the Int PM knob never turns. The audio is fine and you can adjust or map each parameter properly, but the GUI only shows the Ratio knob. The VCV code uses hide() and show() to display them but the MM doesn’t support that.
Maybe it would make more sense if the Int PM knob was in front, so the Ratio knob was hidden since the former is the default active one.
Or… change the ratio knob’s xy position so it doesn’t cover the Int PM knob?
We had this solution on the Oneiroi branch, would that solve things?
(incidentally I’m trying to revive the Oneiroi port on v2.0-dev, as a seperate plugin, you should have recieved a github repo invite - that would also benifit from this change)