OK that fixed it thanks! They run great, passes CPU test (fairly low CPU usage too)
BTW you might consider cleaning up the repo by removing the build directory from the repo – not from your computer, just from the repo itself. The reason is that it’s a huge directory of files that only pertain to your personal computer. Having it there makes it harder to use an automated script to create releases if you want the plugin to be on our website (not to mention making it confusing for other developers to build on their machine and very difficult to stay in sync or contribute since each person’s build/ dir will be different). There are other reasons, too, including security issues with exposing details of your personal computer publicly. A quick search for “git best practices exclude build directory” brings up some helpful info, or tutorials like this
It’s a little tricky to remove a directory or file from the repo once it’s already been added and committed to the repo, but it can be done like this:
First make sure you committed any recent changes you want to keep. Then create a file called “.gitignore” in the root of the repo and put these lines in it:
VCVmodule/build/
meta module/build/
plugin.dylib
plugin.dylib is also created by building, and only will work on your computer, so it’s not good to keep it in the public repo.
Then run some commands like this:
git add .gitignore
git commit -m "Ignoring build directories and plugin.dylib"
git rm -r --cached meta\ module/build
git rm -r --cached VCVmodule/build
git rm --cached VCVmodule/plugin.dylib
git commit -m "Removed build dirs from repo"
rm -r meta\ module/build
rm -r VCVmodule/build
rm VCVmodule/plugin.dylib
Now you can build as normal, and it’ll be friendly to automation scripts, collaboration with other developers, and make it easier to track your changes (e.g. if you look at the commit history for the fix you just made, there are over 11000 lines changed in 37 files! But really all that needed to change was one added line in the CMakeLists.txt file, and renaming one file).
You also might consider removing the .DS_Store files. They’re not needed by anyone but they’re small so not really a practical problem.
Finally, if you want this listed on our site then .mmplugin file will need a version, and it’ll have to be in a github Release, not in the repo itself. (it’s not best practice to have it in the repo anyways – likewise the .vcvplugin files).
We have some instructions for doing that here: