On v2.3.1
I tried first removing the module from the patch and unloading it from Settings > Plugins before uploading the new binary, but all of MM still crashes.
Hmm, is the crash a frozen UI? Any sound?
You should be able to just upload the rebuilt plugin, and it’ll automatically stop the patch, unload the old plugin, and load the new plugin. See if it still happens. I can try to make it happen here if you send me the before and after .mmplugin files, and the patch yml.
The whole UI is frozen and as far as I can tell there is no more processing. Don’t see the device on USB etc.
I’ll try to test audio next time (in my latest tests I wasn’t testing any audio but jack i/o responses using LEDs)
OK, I hit this bug and figured it out. If the currently playing patch contains a module in the plugin that’s reloaded (which is probably the case), and you’re on the PatchView or ModuleView pages, and a module in the patch has some GUI elements that reference a module (like a dynamic display element), then there can be a condition where the modules are unloaded before the GUI page has a chance to clean up the elements, and it ends up referencing a pointer to the deleted module.
I merged the fix in, in case you’re tracking the main branch or the dev releases, but otherwise it’ll be part of v2.4.0
Oh I see! so the issue was related to my test-module using LEDs? thank you for investigating this.
I’m on holiday right now and didn’t have a chance to replicate with some example binaries to share before I left.
When I get back I’ll try the dev release, or if you release v2.4.0 before then I’ll upgrade and test.